fix #663
This commit is contained in:
1 parent
24021e6c6d
commit
c648dae172
3 files changed
+35
-3
No files matched your search
+27
-1
@@ -17,7 +17,10 @@
|
||||
|
||||
package com.pig4cloud.pigx.common.security.component;
|
||||
|
||||
import cn.hutool.core.util.StrUtil;
|
||||
import com.pig4cloud.pigx.common.core.constant.CommonConstants;
|
||||
import com.pig4cloud.pigx.common.core.constant.SecurityConstants;
|
||||
import com.pig4cloud.pigx.common.security.exception.ForbiddenException;
|
||||
import com.pig4cloud.pigx.common.security.service.PigxUser;
|
||||
import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
|
||||
import org.springframework.security.core.Authentication;
|
||||
@@ -25,10 +28,14 @@ import org.springframework.security.core.GrantedAuthority;
|
||||
import org.springframework.security.core.authority.AuthorityUtils;
|
||||
import org.springframework.security.oauth2.provider.token.UserAuthenticationConverter;
|
||||
import org.springframework.util.StringUtils;
|
||||
import org.springframework.web.context.request.RequestContextHolder;
|
||||
import org.springframework.web.context.request.ServletRequestAttributes;
|
||||
|
||||
import javax.servlet.http.HttpServletRequest;
|
||||
import java.util.Collection;
|
||||
import java.util.LinkedHashMap;
|
||||
import java.util.Map;
|
||||
import java.util.Optional;
|
||||
|
||||
/**
|
||||
* @author lengleng
|
||||
@@ -64,8 +71,8 @@ public class PigxUserAuthenticationConverter implements UserAuthenticationConver
|
||||
@Override
|
||||
public Authentication extractAuthentication(Map<String, ?> map) {
|
||||
if (map.containsKey(USERNAME)) {
|
||||
validateTenantId(map);
|
||||
Collection<? extends GrantedAuthority> authorities = getAuthorities(map);
|
||||
|
||||
String username = (String) map.get(USERNAME);
|
||||
Integer id = (Integer) map.get(SecurityConstants.DETAILS_USER_ID);
|
||||
Integer deptId = (Integer) map.get(SecurityConstants.DETAILS_DEPT_ID);
|
||||
@@ -88,4 +95,23 @@ public class PigxUserAuthenticationConverter implements UserAuthenticationConver
|
||||
}
|
||||
throw new IllegalArgumentException("Authorities must be either a String or a Collection");
|
||||
}
|
||||
|
||||
private void validateTenantId(Map<String, ?> map){
|
||||
String headerValue = getCurrentTenantId();
|
||||
Integer userValue = (Integer) map.get(SecurityConstants.DETAILS_TENANT_ID);
|
||||
if(StrUtil.isNotBlank(headerValue) && !userValue.toString().equals(headerValue)){
|
||||
// TODO: 不要提示租户ID不对,避免被穷举
|
||||
throw new ForbiddenException("bad tenant id");
|
||||
}
|
||||
}
|
||||
|
||||
public static Optional<HttpServletRequest> getCurrentHttpRequest() {
|
||||
return Optional.ofNullable(RequestContextHolder.getRequestAttributes())
|
||||
.filter(requestAttributes -> ServletRequestAttributes.class.isAssignableFrom(requestAttributes.getClass()))
|
||||
.map(requestAttributes -> ((ServletRequestAttributes) requestAttributes))
|
||||
.map(ServletRequestAttributes::getRequest);
|
||||
}
|
||||
public static String getCurrentTenantId() {
|
||||
return getCurrentHttpRequest().map(httpServletRequest -> httpServletRequest.getHeader(CommonConstants.TENANT_ID)).orElse(null);
|
||||
}
|
||||
}
|
||||
+4
-2
@@ -27,10 +27,12 @@ import org.springframework.http.HttpStatus;
|
||||
*/
|
||||
@JsonSerialize(using = PigxAuth2ExceptionSerializer.class)
|
||||
public class ForbiddenException extends PigxAuth2Exception {
|
||||
|
||||
public ForbiddenException(String msg, Throwable t) {
|
||||
public ForbiddenException(String msg) {
|
||||
super(msg);
|
||||
}
|
||||
public ForbiddenException(String msg, Throwable t) {
|
||||
super(msg,t);
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getOAuth2ErrorCode() {
|
||||
|
||||
+4
@@ -36,6 +36,10 @@ public class PigxAuth2Exception extends OAuth2Exception {
|
||||
super(msg);
|
||||
}
|
||||
|
||||
public PigxAuth2Exception(String msg, Throwable t) {
|
||||
super(msg,t);
|
||||
}
|
||||
|
||||
public PigxAuth2Exception(String msg, String errorCode) {
|
||||
super(msg);
|
||||
this.errorCode = errorCode;
|
||||
|
||||
Reference in new issue
Block a user